Messages in this thread | | | Date | Fri, 31 Dec 2021 22:35:15 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH v2] crypto: cleanup warning in qm_get_qos_value() |
| |
On Wed, Dec 22, 2021 at 09:29:23AM -0800, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Building with clang static analysis returns this warning: > > qm.c:4382:11: warning: The left operand of '==' is a garbage value > if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) { > ~~~~ ^ > > The call to qm_qos_value_init() can return an error without setting > *val. So check ret before checking *val. > > Fixes: 72b010dc33b9 ("crypto: hisilicon/qm - supports writing QoS int the host") > Signed-off-by: Tom Rix <trix@redhat.com> > --- > v2: Add Fixes: line > > drivers/crypto/hisilicon/qm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |