lkml.org 
[lkml]   [2021]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] usb: gadget: don't release an existing dev->buf
On Sat, Jan 01, 2022 at 01:21:37AM +0800, Hangyu Hua wrote:
> dev->buf does not need to be released if it already exists before
> executing dev_config.
>
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> drivers/usb/gadget/legacy/inode.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
> index 3b58f4fc0a80..eaad03c0252f 100644
> --- a/drivers/usb/gadget/legacy/inode.c
> +++ b/drivers/usb/gadget/legacy/inode.c
> @@ -1826,8 +1826,9 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
> spin_lock_irq (&dev->lock);
> value = -EINVAL;
> if (dev->buf) {
> + spin_unlock_irq(&dev->lock);
> kfree(kbuf);
> - goto fail;
> + return value;
> }
> dev->buf = kbuf;
>
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2021-12-31 18:35    [W:0.035 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site