lkml.org 
[lkml]   [2021]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/24] ARM: dts: exynos: override pins by label in Peach Pit
    Date
    Using node paths to extend or override a device tree node is error
    prone. If there was a typo error, a new node will be created instead of
    extending the existing node. This will lead to run-time errors that
    could be hard to detect.

    A mistyped label on the other hand, will cause a dtc compile error
    (during build time).

    Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    ---
    arch/arm/boot/dts/exynos5420-peach-pit.dts | 44 +++++++++++-----------
    1 file changed, 22 insertions(+), 22 deletions(-)

    diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
    index e76fb104db19..1ae5528e9ebf 100644
    --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
    +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
    @@ -868,27 +868,26 @@ pmic_dvs_1: pmic-dvs-1 {
    };
    };

    -&pinctrl_1 {
    - /* Adjust WiFi drive strengths lower for EMI */
    - sd1_clk: sd1-clk {
    - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    - };
    +/* pinctrl_1 */
    +/* Adjust WiFi drive strengths lower for EMI */
    +&sd1_bus1 {
    + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    +};

    - sd1_cmd: sd1-cmd {
    - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    - };
    +&sd1_bus4 {
    + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    +};

    - sd1_bus1: sd1-bus-width1 {
    - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    - };
    +&sd1_bus8 {
    + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    +};

    - sd1_bus4: sd1-bus-width4 {
    - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    - };
    +&sd1_clk {
    + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    +};

    - sd1_bus8: sd1-bus-width8 {
    - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    - };
    +&sd1_cmd {
    + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    };

    &pinctrl_2 {
    @@ -907,12 +906,13 @@ pmic_dvs_3: pmic-dvs-3 {
    };
    };

    -&pinctrl_3 {
    - /* Drive SPI lines at x2 for better integrity */
    - spi2-bus {
    - samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    - };
    +/* pinctrl_3*/
    +/* Drive SPI lines at x2 for better integrity */
    +&spi2_bus {
    + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV3>;
    +};

    +&pinctrl_3 {
    /* Drive SPI chip select at x2 for better integrity */
    ec_spi_cs: ec-spi-cs {
    samsung,pins = "gpb1-2";
    --
    2.32.0
    \
     
     \ /
      Last update: 2021-12-31 17:21    [W:4.118 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site