lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH RESEND] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN
Date
Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
config BLK_CGROUP_IOCOST.

Hence, ./scripts/checkkconfigsymbols.py warns:

BLK_RQ_IO_DATA_LEN
Referencing files: block/Kconfig

Probably, this select is just some unintended left-over from an earlier
draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
repository. So, drop this dead select to an undefined config.

Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
first submission:
https://lore.kernel.org/all/20211112093728.3237-1-lukas.bulwahn@gmail.com/

Patch is already acked by Tejun.
Jens, please pick this quick minor clean-up patch.

block/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/block/Kconfig b/block/Kconfig
index d5d4197b7ed2..80826e28d0d5 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -136,7 +136,6 @@ config BLK_CGROUP_FC_APPID
config BLK_CGROUP_IOCOST
bool "Enable support for cost model based cgroup IO controller"
depends on BLK_CGROUP
- select BLK_RQ_IO_DATA_LEN
select BLK_RQ_ALLOC_TIME
help
Enabling this option enables the .weight interface for cost
--
2.17.1
\
 
 \ /
  Last update: 2021-12-30 08:33    [W:0.040 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site