lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH linux] usb: xhci-ring: Add return if ret is less than 0
On Thu, Dec 30, 2021 at 06:40:10AM +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
>
> For the robustness of the code, judgment and return should be added here

I do not understand this changelog text at all. Please explain the
problem and why you are making this change much better.

>
> The clang_analyzer complains as follows:
>
> drivers/usb/host/xhci-ring.c:
>
> Value stored to 'ret' is never read
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
> ---
> drivers/usb/host/xhci-ring.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index d0b6806..c4eefe2 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -3721,6 +3721,8 @@ int xhci_queue_bulk_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
> ret = prepare_transfer(xhci, xhci->devs[slot_id],
> ep_index, urb->stream_id,
> 1, urb, 1, mem_flags);
> + if (unlikely(ret < 0))
> + return ret;
> urb_priv->td[1].last_trb = ring->enqueue;
> urb_priv->td[1].last_trb_seg = ring->enq_seg;
> field = TRB_TYPE(TRB_NORMAL) | ring->cycle_state | TRB_IOC;
> --
> 2.15.2
>
>

How did you test this change?

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-12-30 08:02    [W:0.125 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site