lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] lib/mpi: add the return value check of kcalloc
From
Hi Zizhuang,

On 12/30/21 10:51 AM, Zizhuang Deng wrote:
> Add the return value check of kcalloc to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <sunsetdzz@gmail.com>
> ---
> lib/mpi/mpi-mod.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..6fd6900f0798 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -41,6 +41,10 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
> mpi_normalize(m);
> ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
>

Remove this empty line.

> + if (!ctx) {
> + return NULL;
> + }
> +
> if (copy) {
> ctx->m = mpi_copy(m);
> ctx->m_copied = 1;


Thanks for pointing it out. Please send a copy to linux-crypto and
Herbert Xu.

Best regards,
Tianjia

\
 
 \ /
  Last update: 2021-12-30 07:42    [W:0.038 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site