lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH linux] netfilter: Remove unnecessary ret assignment
cgel.zte@gmail.com <cgel.zte@gmail.com> wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
>
> Regardless of whether the subsequent (copy_to_user(user, &info, *len) != 0)
> holds, the value of ret will be assigned a new value.
>
> The clang_analyzer complains as follows:
>
> net/ipv6/netfilter/ip6_tables.c:
>
> Value stored to 'ret' is never read

Please fix this properly:

1. consider adding error unwinding instead.
2. net/ipv4/netfilter/ip_tables.c has same construct

\
 
 \ /
  Last update: 2021-12-30 13:13    [W:0.146 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site