lkml.org 
[lkml]   [2021]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
From
On 30/12/2021 09:41, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore.
> Add the corresponding 'put_device()' in the error handling paths.
>
> Fixes: 4740475 ("memory: mtk-smi: Add device link for smi-sub-common")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> drivers/memory/mtk-smi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> index e201e5976f34..2131f2c9e7ed 100644
> --- a/drivers/memory/mtk-smi.c
> +++ b/drivers/memory/mtk-smi.c
> @@ -386,8 +386,10 @@ static int mtk_smi_device_link_common(struct device *dev, struct device **com_de
> of_node_put(smi_com_node);
> if (smi_com_pdev) {
> /* smi common is the supplier, Make sure it is ready before */
> - if (!platform_get_drvdata(smi_com_pdev))
> + if (!platform_get_drvdata(smi_com_pdev)) {
> + put_device(&smi_com_pdev->dev);
> return -EPROBE_DEFER;
> + }

What about other return paths (-ENODEV, 0)?


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-12-30 11:51    [W:1.342 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site