Messages in this thread Patch in this message | | | From | cgel.zte@gmail ... | Subject | [PATCH linux] ethtool: Remove redundant ret assignments | Date | Thu, 30 Dec 2021 06:26:44 +0000 |
| |
From: luo penghao <luo.penghao@zte.com.cn>
The assignment here will be overwritten, so it should be deleted
The clang_analyzer complains as follows:
net/ethtool/netlink.c:
Value stored to 'ret' is never read
Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: luo penghao <luo.penghao@zte.com.cn> --- net/ethtool/netlink.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c index b3729bd..5e23462 100644 --- a/net/ethtool/netlink.c +++ b/net/ethtool/netlink.c @@ -633,7 +633,6 @@ static void ethnl_default_notify(struct net_device *dev, unsigned int cmd, if (ret < 0) goto err_cleanup; reply_len = ret + ethnl_reply_header_size(); - ret = -ENOMEM; skb = genlmsg_new(reply_len, GFP_KERNEL); if (!skb) goto err_cleanup; -- 2.15.2
| |