Messages in this thread | | | Date | Fri, 3 Dec 2021 14:25:30 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/3] gpio: Get rid of duplicate of_node assignment in the drivers |
| |
On Fri, Dec 03, 2021 at 09:40:55AM +0100, Bartosz Golaszewski wrote: > On Thu, Dec 2, 2021 at 10:17 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > GPIO library does copy the of_node from the parent device of > > the GPIO chip, there is no need to repeat this in the individual > > drivers. Remove these assignment all at once. > > > > For the details one may look into the of_gpio_dev_init() implementation. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > I have a bad feeling about this but I've gone through the drivers in > this patch and it seems like you don't update any of the drivers that > use multiple child OF nodes so I can't really point out any obvious > bug.
Yes, like I said it's just a series to kick off the conversion. I left the corner cases to the last.
> I have another change I'm working on that's related, let me send it shortly.
Do you mean it should be attached to the series?
-- With Best Regards, Andy Shevchenko
| |