lkml.org 
[lkml]   [2021]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/2] usb: gadget: don't release an existing dev->buf
    Date
    dev->buf does not need to be released if it already exists before
    executing dev_config.

    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
    ---
    drivers/usb/gadget/legacy/inode.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
    index 3b58f4fc0a80..564352035ac1 100644
    --- a/drivers/usb/gadget/legacy/inode.c
    +++ b/drivers/usb/gadget/legacy/inode.c
    @@ -1826,8 +1826,9 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
    spin_lock_irq (&dev->lock);
    value = -EINVAL;
    if (dev->buf) {
    + spin_unlock_irq(&dev->lock);
    kfree(kbuf);
    - goto fail;
    + return value;
    }
    dev->buf = kbuf;

    --
    2.25.1
    \
     
     \ /
      Last update: 2021-12-30 05:39    [W:4.914 / U:0.976 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site