Messages in this thread | | | Date | Wed, 29 Dec 2021 18:56:55 +0200 | From | Laurent Pinchart <> | Subject | Re: [PATCH 2/3] arm64: dts: renesas: r8a77961: Add lvds0 device node |
| |
Hi Nikita,
Thank you for the patch.
On Fri, Dec 24, 2021 at 08:23:08AM +0300, Nikita Yushchenko wrote: > Add the missing lvds0 node for the R-Car M3-W+ SoC. > > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com> > --- > arch/arm64/boot/dts/renesas/r8a77961.dtsi | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > index 86d59e7e1a87..a34d5b1d6431 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi > @@ -2718,6 +2718,33 @@ du_out_hdmi0: endpoint { > port@2 { > reg = <2>; > du_out_lvds0: endpoint { > + remote-endpoint = <&lvds0_in>; > + }; > + }; > + }; > + }; > + > + lvds0: lvds@feb90000 { > + compatible = "renesas,r8a77961-lvds"; > + reg = <0 0xfeb90000 0 0x14>; > + clocks = <&cpg CPG_MOD 727>; > + power-domains = <&sysc R8A77961_PD_ALWAYS_ON>; > + resets = <&cpg 727>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + lvds0_in: endpoint { > + remote-endpoint = <&du_out_lvds0>; > + }; > + }; > + port@1 { > + reg = <1>; > + lvds0_out: endpoint { > };
Endpoints must have a remote-endpoint property. Let's drop the endpoint here and keep the port only, the endpoint can be declared in board files.
If you're fine with this change I can make it when applying the patch.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> }; > };
-- Regards,
Laurent Pinchart
| |