lkml.org 
[lkml]   [2021]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] THERMAL: Add THERMAL driver for Sunplus SP7021
Hi Li-hao,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Li-hao-Kuo/Add-THERMAL-control-driver-for-Sunplus-SP7021-SoC/20211223-130720
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211230/202112300008.jdRkNNeV-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/99e97d44b9115aad59fc953c2945c7cbda1d57bb
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Li-hao-Kuo/Add-THERMAL-control-driver-for-Sunplus-SP7021-SoC/20211223-130720
git checkout 99e97d44b9115aad59fc953c2945c7cbda1d57bb
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/thermal/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/thermal/sunplus_thermal.c:44:7: warning: no previous prototype for 'sp7021_otp_coef_read' [-Wmissing-prototypes]
44 | char *sp7021_otp_coef_read(struct device *dev, ssize_t *len)
| ^~~~~~~~~~~~~~~~~~~~


vim +/sp7021_otp_coef_read +44 drivers/thermal/sunplus_thermal.c

43
> 44 char *sp7021_otp_coef_read(struct device *dev, ssize_t *len)
45 {
46 char *ret = NULL;
47 struct nvmem_cell *c = nvmem_cell_get(dev, "therm_calib");
48
49 if (IS_ERR_OR_NULL(c)) {
50 dev_err(dev, "OTP read failure:%ld", PTR_ERR(c));
51 return NULL;
52 }
53 ret = nvmem_cell_read(c, len);
54 nvmem_cell_put(c);
55 dev_dbg(dev, "%d bytes read from OTP", *len);
56 return ret;
57 }
58

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2021-12-29 17:29    [W:0.532 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site