Messages in this thread | | | From | Alexander Aring <> | Date | Wed, 29 Dec 2021 09:30:59 -0500 | Subject | Re: [net-next 12/18] net: mac802154: Handle scan requests |
| |
Hi,
On Wed, 22 Dec 2021 at 10:58, Miquel Raynal <miquel.raynal@bootlin.com> wrote: ... > +{ > + bool promiscuous_on = mac802154_check_promiscuous(local); > + int ret; > + > + if ((state && promiscuous_on) || (!state && !promiscuous_on)) > + return 0; > + > + ret = drv_set_promiscuous_mode(local, state); > + if (ret) > + pr_err("Failed to %s promiscuous mode for SW scanning", > + state ? "set" : "reset"); > +
The semantic of promiscuous mode on the driver layer is to turn off ack response, address filtering and crc checking. Some transceivers don't allow a more fine tuning on what to enable/disable. I think we should at least do the checksum checking per software then?
Sure there is a possible tune up for more "powerful" transceivers then...
- Alex
| |