lkml.org 
[lkml]   [2021]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net/usb: remove goto in ax88772_reset()
On Wed, Dec 29, 2021 at 03:57:30PM +0300, Adam Kandur wrote:
> goto statements in ax88772_reset() in net/usb/asix_devices.c are used
> to return ret variable. As function by default returns 0 if ret
> variable >= 0 and "out:" only returns ret, I assume goto might be
> removed.
>
> Signed-off-by: Adam Kandur <sys.arch.adam@gmail.com>
>
> ---
> drivers/net/usb/asix_devices.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 4514d35ef..9de5fc53f 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -332,23 +332,20 @@ static int ax88772_reset(struct usbnet *dev)
> ret = asix_write_cmd(dev, AX_CMD_WRITE_NODE_ID, 0, 0,
> ETH_ALEN, data->mac_addr, 0);
> if (ret < 0)
> - goto out;
> + return ret;
>
> /* Set RX_CTL to default values with 2k buffer, and enable cactus */
> ret = asix_write_rx_ctl(dev, AX_DEFAULT_RX_CTL, 0);
> if (ret < 0)
> - goto out;
> + return ret;
>
> ret = asix_write_medium_mode(dev, AX88772_MEDIUM_DEFAULT, 0);
> if (ret < 0)
> - goto out;
> + return ret;
>
> phy_start(priv->phydev);
>
> return 0;
> -
> -out:
> - return ret;
> }

There is nothing wrong with the goto here, it's the common error path
style for the kernel. Why should it be removed? What is the benefit
here?

thanks,

greg k-h

\
 
 \ /
  Last update: 2021-12-29 14:15    [W:0.098 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site