Messages in this thread | | | Date | Tue, 28 Dec 2021 21:03:44 +0000 | From | Daniel Golle <> | Subject | [PATCH v8 0/3] net: ethernet: mtk_eth_soc: refactoring and Clause 45 |
| |
As it turned out some clean-up would be needed, first address return value and type of mdio read and write functions in mtk_eth_soc and generally clean up and unify both functions. Also refactor IAC register definitions to use bitfield helper macros to get rid of constants previously used as mask or shift values. Then add support to access Clause 45 phy registers, using the newly introcuced helper macros suggested by Russell King to access the Clause 45 device and register address encoded in the 32-bit parameter.
This series is tested on MediaTek MT7622AV based Bananapi BPi-R64 board having MediaTek MT7531BE DSA gigE switch using Clause 22 MDIO and MediaTek MT7622BV based Ubiquiti UniFi 6 LR access point having Aquantia AQR112C PHY using Clause 45 MDIO.
v8: add patch from Russel King, switch to bitfield helper macros v7: remove unneeded variables and order OR-ed call parameters v6: further clean up functions and more cleanly separate patches v5: fix wrong variable name in first patch covered by follow-up patch v4: clean-up return values and types, split into two commits v3: return -1 instead of 0xffff on error in _mtk_mdio_write v2: use MII_DEVADDR_C45_SHIFT and MII_REGADDR_C45_MASK to extract device id and register address. Unify read and write functions to have identical types and parameter names where possible as we are anyway already replacing both function bodies.
Daniel Golle (2): net: ethernet: mtk_eth_soc: fix return value and refactor MDIO ops net: ethernet: mtk_eth_soc: implement Clause 45 MDIO access
Russell King (Oracle) (1): net: mdio: add helpers to extract clause 45 regad and devad fields
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 73 ++++++++++++++------- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 19 ++++-- include/linux/mdio.h | 12 ++++ 3 files changed, 77 insertions(+), 27 deletions(-)
-- 2.34.1
| |