Messages in this thread | | | Date | Tue, 28 Dec 2021 09:36:32 -0800 | Subject | Re: [PATCH] drm/msm/dp: Fix a potential double free in an error handling path | From | Kuogee Hsieh <> |
| |
On 12/26/2021 7:14 AM, Christophe JAILLET wrote: > 'dp_bridge' is devm_alloc'ed, so there is no need to free it explicitly or > there will be a double free(). > > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com> > --- > drivers/gpu/drm/msm/dp/dp_drm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c > index 188e77c59885..d4d360d19eba 100644 > --- a/drivers/gpu/drm/msm/dp/dp_drm.c > +++ b/drivers/gpu/drm/msm/dp/dp_drm.c > @@ -243,7 +243,6 @@ struct drm_bridge *msm_dp_bridge_init(struct msm_dp *dp_display, struct drm_devi > rc = drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); > if (rc) { > DRM_ERROR("failed to attach bridge, rc=%d\n", rc); > - kfree(dp_bridge); > return ERR_PTR(rc); > } >
| |