Messages in this thread | | | Date | Tue, 28 Dec 2021 20:33:23 +0800 | Subject | Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read | From | JeffleXu <> |
| |
On 12/27/21 11:36 PM, Matthew Wilcox wrote: > On Mon, Dec 27, 2021 at 08:54:40PM +0800, Jeffle Xu wrote: >> + spin_lock(&cache->reqs_lock); >> + ret = idr_alloc(&cache->reqs, req, 0, 0, GFP_KERNEL); > > GFP_KERNEL while holding a spinlock?
Right. Thanks for pointing it out.
> > You should be using an XArray instead of an IDR in new code anyway. >
Regards.
-- Thanks, Jeffle
| |