lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v9, 2/2] net: Add dm9051 driver
On Mon, 27 Dec 2021 18:02:33 +0800 Joseph CHAMG wrote:
> +static inline void dm9051_phyup_lock(struct board_info *db)
> +{
> + int val, ret;
> +
> + mutex_lock(&db->addr_lock);
> +
> + ret = dm9051_phy_read(db, MII_BMCR, &val);
> + if (ret)
> + return;
> +
> + /* BMCR Power-up PHY */
> + ret = dm9051_phy_write(db, MII_BMCR, val & ~0x0800);
> + if (ret)
> + return;
> +
> + /* GPR Power-up PHY */
> + dm9051_iow(db, DM9051_GPR, 0);
> + mdelay(1); /* need for activate phyxcer */
> +
> + mutex_unlock(&db->addr_lock);
> +}
> +
> +static inline void dm9051_phydown_lock(struct board_info *db)
> +{
> + mutex_lock(&db->addr_lock);
> + dm9051_iow(db, DM9051_GPR, 0x01); /* Power-Down PHY */
> + mutex_unlock(&db->addr_lock);
> +}

Please remove the 'inline' qualifier from functions in C sources.
Compiler will know which static functions to inline these days.

\
 
 \ /
  Last update: 2021-12-28 02:51    [W:0.048 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site