Messages in this thread | | | Date | Mon, 27 Dec 2021 17:43:02 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH v7 0/2] net: ethernet: mtk_soc_eth: implement Clause 45 MDIO access |
| |
On Tue, 28 Dec 2021 01:10:21 +0000 Daniel Golle wrote: > As it turned out some clean-up would be needed, first address return > value and type of mdio read and write functions in mtk_eth_soc and > generally clean up and unify both functions. > Then add support to access Clause 45 phy registers. > > Both commits are tested on the Bananapi BPi-R64 board having MediaTek > MT7531BE DSA gigE switch using clause 22 MDIO and Ubiquiti UniFi 6 LR > access point having Aquantia AQR112C PHY using clause 45 MDIO. > > v7: remove unneeded variables and order OR-ed call parameters > v6: further clean up functions and more cleanly separate patches > v5: fix wrong variable name in first patch covered by follow-up patch > v4: clean-up return values and types, split into two commits > v3: return -1 instead of 0xffff on error in _mtk_mdio_write > v2: use MII_DEVADDR_C45_SHIFT and MII_REGADDR_C45_MASK to extract > device id and register address. Unify read and write functions to > have identical types and parameter names where possible as we are > anyway already replacing both function bodies.
Please stop reposting this series (1) so often; (2) as a flat response to an old version. You are completely confusing patch series detection, at least in patchwork.
Try git send-email and please allow at least 12 hours between postings for reviewers to comment.
| |