lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 07/10] ata: pata_platform: Merge pata_of_platform into pata_platform
From
Date
On 12/27/21 11:54 PM, Sergey Shtylyov wrote:

[...]
>> ...
>>
>>> + if ((pdev->num_resources != 3) && (pdev->num_resources != 2)) {
>>> + dev_err(&pdev->dev, "invalid number of resources\n");
>>> + return -EINVAL;
>>
>> return dev_err_probe(); ?
>>
>>> + }
>>
>> ...
>>
>>> + if (!dev_of_node(&pdev->dev))
>>> + ret = pata_platform_get_pdata(pdev, priv);
>>> + else
>>> + ret = pata_of_platform_get_pdata(pdev, priv);
>>
>> What the difference between them?
>
> One parses DT props into the private structure, the other inits this structure without DT...
>
>> Can't you unify them and leave only
>> DT related part separately?
>
> He can't -- grep *defconfig for PATA_PLATFORM=, please.

I take it back -- I think I misunderstood. :-)

> [...]

MBR, Sergey

\
 
 \ /
  Last update: 2021-12-27 21:57    [W:0.056 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site