Messages in this thread | | | Subject | Re: [PATCH v3] ima: silence measurement list hexdump during kexec | From | Mimi Zohar <> | Date | Mon, 27 Dec 2021 10:54:12 -0500 |
| |
On Mon, 2021-12-27 at 11:52 -0300, Bruno Meneguele wrote: > The measurement list is being dumped during soft resets (kexec) through the > call to print_hex_dump(KERN_DEBUG, ...) without considering the DEBUG > compilation flag. With that, to avoid dumping this information to the system > log whenever a soft reset happens during boot process, since the default > console loglevel is generally set to 7 (debug) during boot, guard the call > to print_hex_dump() with #ifdef for the DEBUG cflag.
The patch description needs to be rewritten/simplified. If the only problem is that "the console loglevel is generally set to 7 (debug)", why not begin with the patch description with that?
Other things to consider including in the patch description: - any side effects of the change (e.g. ability to dynamically enable output)?
thanks,
Mimi
| |