lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 018/128] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts()
    Date
    From: José Expósito <jose.exposito89@gmail.com>

    [ Upstream commit bee90911e0138c76ee67458ac0d58b38a3190f65 ]

    The wrong goto label was used for the error case and missed cleanup of the
    pkt allocation.

    Fixes: d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields")
    Link: https://lore.kernel.org/r/20211208175238.29983-1-jose.exposito89@gmail.com
    Addresses-Coverity-ID: 1493352 ("Resource leak")
    Signed-off-by: José Expósito <jose.exposito89@gmail.com>
    Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c b/drivers/infiniband/hw/qib/qib_user_sdma.c
    index ac11943a5ddb0..bf2f30d67949d 100644
    --- a/drivers/infiniband/hw/qib/qib_user_sdma.c
    +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c
    @@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd,
    &addrlimit) ||
    addrlimit > type_max(typeof(pkt->addrlimit))) {
    ret = -EINVAL;
    - goto free_pbc;
    + goto free_pkt;
    }
    pkt->addrlimit = addrlimit;

    --
    2.34.1


    \
     
     \ /
      Last update: 2021-12-27 16:54    [W:4.150 / U:0.784 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site