lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 120/128] pinctrl: mediatek: fix global-out-of-bounds issue
    Date
    From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>

    commit 2d5446da5acecf9c67db1c9d55ae2c3e5de01f8d upstream.

    When eint virtual eint number is greater than gpio number,
    it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.

    Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
    Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
    Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
    Link: https://lore.kernel.org/r/20211110071900.4490-2-zhiyong.tao@mediatek.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
    @@ -285,8 +285,12 @@ static int mtk_xt_get_gpio_n(void *data,
    desc = (const struct mtk_pin_desc *)hw->soc->pins;
    *gpio_chip = &hw->chip;

    - /* Be greedy to guess first gpio_n is equal to eint_n */
    - if (desc[eint_n].eint.eint_n == eint_n)
    + /*
    + * Be greedy to guess first gpio_n is equal to eint_n.
    + * Only eint virtual eint number is greater than gpio number.
    + */
    + if (hw->soc->npins > eint_n &&
    + desc[eint_n].eint.eint_n == eint_n)
    *gpio_n = eint_n;
    else
    *gpio_n = mtk_xt_find_eint_num(hw, eint_n);

    \
     
     \ /
      Last update: 2021-12-27 16:53    [W:4.580 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site