lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 077/128] ipmi: bail out if init_srcu_struct fails
    Date
    From: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

    commit 2b5160b12091285c5aca45980f100a9294af7b04 upstream.

    In case, init_srcu_struct fails (because of memory allocation failure), we
    might proceed with the driver initialization despite srcu_struct not being
    entirely initialized.

    Fixes: 913a89f009d9 ("ipmi: Don't initialize anything in the core until something uses it")
    Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
    Cc: Corey Minyard <cminyard@mvista.com>
    Cc: stable@vger.kernel.org
    Message-Id: <20211217154410.1228673-1-cascardo@canonical.com>
    Signed-off-by: Corey Minyard <cminyard@mvista.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/ipmi/ipmi_msghandler.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/char/ipmi/ipmi_msghandler.c
    +++ b/drivers/char/ipmi/ipmi_msghandler.c
    @@ -5148,7 +5148,9 @@ static int ipmi_init_msghandler(void)
    if (initialized)
    goto out;

    - init_srcu_struct(&ipmi_interfaces_srcu);
    + rv = init_srcu_struct(&ipmi_interfaces_srcu);
    + if (rv)
    + goto out;

    timer_setup(&ipmi_timer, ipmi_timeout, 0);
    mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);

    \
     
     \ /
      Last update: 2021-12-27 16:53    [W:4.044 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site