lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 23/38] Input: atmel_mxt_ts - fix double free in mxt_read_info_block
    Date
    From: José Expósito <jose.exposito89@gmail.com>

    commit 12f247ab590a08856441efdbd351cf2cc8f60a2d upstream.

    The "id_buf" buffer is stored in "data->raw_info_block" and freed by
    "mxt_free_object_table" in case of error.

    Return instead of jumping to avoid a double free.

    Addresses-Coverity-ID: 1474582 ("Double free")
    Fixes: 068bdb67ef74 ("Input: atmel_mxt_ts - fix the firmware update")
    Signed-off-by: José Expósito <jose.exposito89@gmail.com>
    Link: https://lore.kernel.org/r/20211212194257.68879-1-jose.exposito89@gmail.com
    Cc: stable@vger.kernel.org
    Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/input/touchscreen/atmel_mxt_ts.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/input/touchscreen/atmel_mxt_ts.c
    +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
    @@ -1809,7 +1809,7 @@ static int mxt_read_info_block(struct mx
    if (error) {
    dev_err(&client->dev, "Error %d parsing object table\n", error);
    mxt_free_object_table(data);
    - goto err_free_mem;
    + return error;
    }

    data->object_table = (struct mxt_object *)(id_buf + MXT_OBJECT_START);

    \
     
     \ /
      Last update: 2021-12-27 16:37    [W:4.126 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site