lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 10/19] ALSA: jack: Check the return value of kstrdup()
    Date
    From: Xiaoke Wang <xkernel.wang@foxmail.com>

    commit c01c1db1dc632edafb0dff32d40daf4f9c1a4e19 upstream.

    kstrdup() can return NULL, it is better to check the return value of it.

    Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/tencent_094816F3522E0DC704056C789352EBBF0606@qq.com
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/core/jack.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/sound/core/jack.c
    +++ b/sound/core/jack.c
    @@ -234,6 +234,10 @@ int snd_jack_new(struct snd_card *card,
    return -ENOMEM;

    jack->id = kstrdup(id, GFP_KERNEL);
    + if (jack->id == NULL) {
    + kfree(jack);
    + return -ENOMEM;
    + }

    /* don't creat input device for phantom jack */
    if (!phantom_jack) {

    \
     
     \ /
      Last update: 2021-12-27 16:29    [W:2.229 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site