Messages in this thread | | | Date | Mon, 27 Dec 2021 17:14:36 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 19/26] x86/tdx: Make pages shared in ioremap() |
| |
On Mon, Dec 27, 2021 at 12:51:21PM +0100, Borislav Petkov wrote: > On Fri, Dec 24, 2021 at 02:03:00PM +0300, Kirill A. Shutemov wrote: > > Okay. Meanwhile I leave it this way: > > > > pgprot_t pgprot_cc_encrypted(pgprot_t prot) > > { > > if (cc_platform_has(CC_ATTR_MEM_ENCRYPT)) { > > if (cc_platform_has(CC_ATTR_GUEST_TDX)) > > return __pgprot(pgprot_val(prot) & ~tdx_shared_mask()); > > else if (sme_me_mask) > > return __pgprot(__sme_set(pgprot_val(prot))); > > else > > WARN_ON_ONCE(1); > > I'm wondering if defining a generic cc_attr especially for this: > > if (cc_platform_has(CC_ATTR_MEMORY_SHARING)) > > to mean, the CC guest needs to do special stuff in order to share memory > with the host (naming sucks, ofc) would be cleaner?
Looks like CC_ATTR_MEM_ENCRYPT already does this. The attribute doesn't have much meaning beyond that, no?
-- Kirill A. Shutemov
| |