lkml.org 
[lkml]   [2021]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] m68k: introduce a virtual m68k machine
Hi Laurent,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on geert-m68k/for-next]
[also build test WARNING on linux/master linus/master v5.16-rc7 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Laurent-Vivier/m68k-Add-Virtual-M68k-Machine/20211227-174054
base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git for-next
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20211227/202112272147.UoQokuQR-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/02e0dceb9e3bfcc8ef254308394ddb2a6a4cac2f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Laurent-Vivier/m68k-Add-Virtual-M68k-Machine/20211227-174054
git checkout 02e0dceb9e3bfcc8ef254308394ddb2a6a4cac2f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash arch/m68k/virt/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/m68k/virt/config.c:56:12: warning: no previous prototype for 'virt_parse_bootinfo' [-Wmissing-prototypes]
56 | int __init virt_parse_bootinfo(const struct bi_record *record)
| ^~~~~~~~~~~~~~~~~~~
>> arch/m68k/virt/config.c:97:13: warning: no previous prototype for 'config_virt' [-Wmissing-prototypes]
97 | void __init config_virt(void)
| ^~~~~~~~~~~
--
>> arch/m68k/virt/ints.c:48:13: warning: no previous prototype for 'virt_nmi_handler' [-Wmissing-prototypes]
48 | irqreturn_t virt_nmi_handler(int irq, void *dev_id)
| ^~~~~~~~~~~~~~~~


vim +/virt_parse_bootinfo +56 arch/m68k/virt/config.c

51
52 /*
53 * Parse a virtual-m68k-specific record in the bootinfo
54 */
55
> 56 int __init virt_parse_bootinfo(const struct bi_record *record)
57 {
58 int unknown = 0;
59 const void *data = record->data;
60
61 switch (be16_to_cpu(record->tag)) {
62 case BI_VIRT_QEMU_VERSION:
63 virt_bi_data.qemu_version = be32_to_cpup(data);
64 break;
65 case BI_VIRT_GF_PIC_BASE:
66 virt_bi_data.pic.mmio = be32_to_cpup(data);
67 data += 4;
68 virt_bi_data.pic.irq = be32_to_cpup(data);
69 break;
70 case BI_VIRT_GF_RTC_BASE:
71 virt_bi_data.rtc.mmio = be32_to_cpup(data);
72 data += 4;
73 virt_bi_data.rtc.irq = be32_to_cpup(data);
74 break;
75 case BI_VIRT_GF_TTY_BASE:
76 virt_bi_data.tty.mmio = be32_to_cpup(data);
77 data += 4;
78 virt_bi_data.tty.irq = be32_to_cpup(data);
79 break;
80 case BI_VIRT_CTRL_BASE:
81 virt_bi_data.ctrl.mmio = be32_to_cpup(data);
82 data += 4;
83 virt_bi_data.ctrl.irq = be32_to_cpup(data);
84 break;
85 case BI_VIRT_VIRTIO_BASE:
86 virt_bi_data.virtio.mmio = be32_to_cpup(data);
87 data += 4;
88 virt_bi_data.virtio.irq = be32_to_cpup(data);
89 break;
90 default:
91 unknown = 1;
92 break;
93 }
94 return unknown;
95 }
96
> 97 void __init config_virt(void)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

\
 
 \ /
  Last update: 2021-12-27 15:00    [W:0.043 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site