Messages in this thread | | | Subject | Re: [PATCH] clk: socfpga: remove redundant assignment on division | From | Dinh Nguyen <> | Date | Mon, 27 Dec 2021 04:38:44 -0600 |
| |
On 12/20/21 6:37 PM, Colin Ian King wrote: > The variable parent_rate is being divided by div and the result > is re-assigned to parent_rate before being returned. The assignment > is redundant, replace /= operator with just / operator. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/clk/socfpga/clk-pll-s10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/socfpga/clk-pll-s10.c b/drivers/clk/socfpga/clk-pll-s10.c > index 70076a80149d..e444e4a0ee53 100644 > --- a/drivers/clk/socfpga/clk-pll-s10.c > +++ b/drivers/clk/socfpga/clk-pll-s10.c > @@ -113,7 +113,7 @@ static unsigned long clk_boot_clk_recalc_rate(struct clk_hw *hwclk, > SWCTRLBTCLKSEL_MASK) >> > SWCTRLBTCLKSEL_SHIFT); > div += 1; > - return parent_rate /= div; > + return parent_rate / div; > } >
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
| |