lkml.org 
[lkml]   [2021]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] kernel: time: Return ENXIO instead of ENODEV when call smp_call_function_single fail in clockevents_unbind
From
Date
Hello:

The original mail was not sent successfully, so I send it again with
another mailbox.

Thanks.

On 12/19/21 11:29 PM, gchen@itskywalker.com wrote:
> From: Chen Gang <gchen@itskywalker.com>
>
> smp_call_function_single will return -ENXIO for failure, so ENXIO needs
> to be as the default value of cu.res for return instead of ENODEV.
>
> Signed-off-by: Chen Gang <gchen@itskywalker.com>
> ---
> kernel/time/clockevents.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
> index 003ccf338d20..59b83bee03e6 100644
> --- a/kernel/time/clockevents.c
> +++ b/kernel/time/clockevents.c
> @@ -416,7 +416,7 @@ static void __clockevents_unbind(void *arg)
> */
> static int clockevents_unbind(struct clock_event_device *ced, int cpu)
> {
> - struct ce_unbind cu = { .ce = ced, .res = -ENODEV };
> + struct ce_unbind cu = { .ce = ced, .res = -ENXIO };
>
> smp_call_function_single(cpu, __clockevents_unbind, &cu, 1);
> return cu.res;
>


\
 
 \ /
  Last update: 2021-12-25 06:22    [W:0.034 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site