Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Sat, 25 Dec 2021 17:13:05 +0000 | Subject | Re: [PATCH v3 03/10] ata: pata_of_platform: Use platform_get_irq_optional() to get the interrupt |
| |
Hi Andy,
Thank you for the review.
On Sat, Dec 25, 2021 at 5:02 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sat, Dec 25, 2021 at 3:55 AM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > > allocation of IRQ resources in DT core code, this causes an issue > > when using hierarchical interrupt domains using "interrupts" property > > in the node as this bypasses the hierarchical setup and messes up the > > irq chaining. > > > > In preparation for removal of static setup of IRQ resource from DT core > > code use platform_get_irq_optional(). > > ... > > > + irq = platform_get_irq_optional(ofdev, 0); > > + if (irq < 0 && irq != -ENXIO) > > + return irq; > > + > > + if (irq > 0) { > > > + memset(&irq_res, 0x0, sizeof(struct resource)); > > Why do you need that variable at all? > Are you referring to the irq_res variable? That's because __pata_platform_probe() requires it.
> 0x0 -> 0 > sizeof(irq_res) > OK, I will update it.
Cheers, Prabhakar
| |