Messages in this thread | | | Date | Sat, 25 Dec 2021 16:16:02 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 2/8] net: pxa168_eth: Use platform_get_irq() to get the interrupt |
| |
> >> + goto err_netdev; > >> + BUG_ON(dev->irq < 0); > > > > > > ??? What is this and how it supposed to work? > > > .. should have been BUG_ON(dev->irq < 0);
Is this fatal to the machine as a whole, now way to recover, all that can be done is to limit the damage while it explodes?
If not, please use WARN_ON(), not BUG_ON(). There is an email from Linus about this, not using BUG_ON() in general.
Andrew
| |