Messages in this thread | | | From | Max Filippov <> | Date | Fri, 24 Dec 2021 03:28:42 -0800 | Subject | Re: [PATCH] net: xtensa: use strscpy to copy strings |
| |
On Mon, Dec 20, 2021 at 12:46 AM Jason Wang <wangborong@cdjrlc.com> wrote: > > The strlcpy should not be used because it doesn't limit the source > length. So that it will lead some potential bugs. > > But the strscpy doesn't require reading memory from the src string > beyond the specified "count" bytes, and since the return value is > easier to error-check than strlcpy()'s. In addition, the implementation > is robust to the string changing out from underneath it, unlike the > current strlcpy() implementation. > > Thus, replace strlcpy with strscpy. > > Signed-off-by: Jason Wang <wangborong@cdjrlc.com> > --- > arch/xtensa/platforms/iss/network.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to my xtensa tree. Thanks.
-- Max
| |