Messages in this thread | | | Date | Thu, 23 Dec 2021 19:47:57 +0100 | Subject | Re: [PATCH] platform/x86: intel_pmc_core: fix memleak on registration failure | From | Hans de Goede <> |
| |
Hi,
On 12/22/21 11:50, Johan Hovold wrote: > In case device registration fails during module initialisation, the > platform device structure needs to be freed using platform_device_put() > to properly free all resources (e.g. the device name). > > Fixes: 938835aa903a ("platform/x86: intel_pmc_core: do not create a static struct device") > Cc: stable@vger.kernel.org # 5.9 > Signed-off-by: Johan Hovold <johan@kernel.org>
Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
> --- > drivers/platform/x86/intel/pmc/pltdrv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/pmc/pltdrv.c b/drivers/platform/x86/intel/pmc/pltdrv.c > index 73797680b895..15ca8afdd973 100644 > --- a/drivers/platform/x86/intel/pmc/pltdrv.c > +++ b/drivers/platform/x86/intel/pmc/pltdrv.c > @@ -65,7 +65,7 @@ static int __init pmc_core_platform_init(void) > > retval = platform_device_register(pmc_core_device); > if (retval) > - kfree(pmc_core_device); > + platform_device_put(pmc_core_device); > > return retval; > } >
| |