lkml.org 
[lkml]   [2021]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] wwan: Replace kernel.h with the necessary inclusions
On Wed, Dec 22, 2021 at 11:38:44PM +0300, Sergey Ryazanov wrote:
> On Wed, Dec 22, 2021 at 7:32 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > When kernel.h is used in the headers it adds a lot into dependency hell,
> > especially when there are circular dependencies are involved.
> >
> > Replace kernel.h inclusion with the list of what is really being used.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Subject and description do not cover cleanup of includes besides the
> kernel.h. But that does not seem like a big issue, so:

Not sure what it's supposed from me to do. The forward declarations are
the tighten part of the cleanup (*) and it's exactly what is happening here,
i.e. replacing kernel.h "with the list of what is really being used".

*) Either you need a header, or you need a forward declaration, or rely on
the compiler not to be so strict. I prefer the second option out of three.

> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

Thanks!

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2021-12-23 11:16    [W:0.564 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site