Messages in this thread | | | Date | Wed, 22 Dec 2021 18:15:11 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH] firmware: arm_scmi: replace resevered identifiers in macros |
| |
On Wed, Dec 22, 2021 at 09:25:19AM -0800, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > Identifiers starting with __ are resevered. Replace __X with X. > > The arguments to these macros are pointers. The macros only reads > values. There is no need to make copies of the pointers, use them > directly. >
Agreed and thanks for the patch.
However the original patch was modified and these macros were moved to inline functions[0] after the initial build warnings from the build bot[1]. Sorry my reply to the bot seems to have got lost and didn't make it to the list.
-- Regards, Sudeep
[0] https://git.kernel.org/sudeep.holla/c/a690b7e6e7 [1] https://lore.kernel.org/lkml/202112211457.TlWRYcoq-lkp@intel.com/
| |