lkml.org 
[lkml]   [2021]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 4/8] sched: powerpc: Remove unused TASK_SIZE_OF
    Date


    Le 22/12/2021 à 04:02, Guo Ren a écrit :
    > On Wed, Dec 22, 2021 at 2:43 AM Christophe Leroy
    > <christophe.leroy@csgroup.eu> wrote:
    >>
    >>
    >>
    >> Le 21/12/2021 à 18:00, guoren@kernel.org a écrit :
    >>> From: Guo Ren <guoren@linux.alibaba.com>
    >>>
    >>> This macro isn't used in Linux sched, now. Delete in
    >>> include/linux/sched.h and arch's include/asm.
    >>>
    >>> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
    >>> ---
    >>> arch/powerpc/include/asm/task_size_64.h | 6 ++----
    >>> 1 file changed, 2 insertions(+), 4 deletions(-)
    >>>
    >>> diff --git a/arch/powerpc/include/asm/task_size_64.h b/arch/powerpc/include/asm/task_size_64.h
    >>> index c993482237ed..7e2eca4fac4d 100644
    >>> --- a/arch/powerpc/include/asm/task_size_64.h
    >>> +++ b/arch/powerpc/include/asm/task_size_64.h
    >>> @@ -44,12 +44,10 @@
    >>> */
    >>> #define TASK_SIZE_USER32 (0x0000000100000000UL - (1 * PAGE_SIZE))
    >>>
    >>> -#define TASK_SIZE_OF(tsk) \
    >>> - (test_tsk_thread_flag(tsk, TIF_32BIT) ? TASK_SIZE_USER32 : \
    >>> +#define TASK_SIZE \
    >>> + (test_tsk_thread_flag(current, TIF_32BIT) ? TASK_SIZE_USER32 : \
    >>> TASK_SIZE_USER64)
    >>
    >> I think you should use test_thread_flag() instead.
    >>
    >> Or even better: use is_32bit_task() and bring back this macro as a
    >> single line, something like:
    >>
    >> #define TASK_SIZE (is_32bit_task() ? TASK_SIZE_USER32 : TASK_SIZE_USER64)
    > Okay, looks better. I would fix it in the next version.

    Note that is_32bit_task() exists on powerpc, parisc and sparc.

    For other ones you can still use test_thread_flag() instead of
    test_tsk_thread_flag(current)
    \
     
     \ /
      Last update: 2021-12-22 08:27    [W:3.176 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site