Messages in this thread | | | Subject | Re: [PATCH] perf pmu: Fix event list for uncore PMUs | From | John Garry <> | Date | Wed, 22 Dec 2021 13:08:20 +0000 |
| |
On 21/12/2021 20:48, Arnaldo Carvalho de Melo wrote: >> Now thinking a bit more I am not confident that this patch is a full fix. >> >> arm have heterogeneous CPU systems as well - which are not "hybrid" - and I >> need to ensure that aliasing is still working properly there, as I think >> that this following check would stop removing duplicates there: >> >> + /* uncore PMUs */ >> + if (!alias_a->is_cpu && !alias_b->is_cpu) >> + return true; >> + return false; > I was about to process this, do you think its better to revert the > original patch while this gets fixed?
I think that the v2 should now be ok.
@jirka, can you kindly help to check that?
BTW, my patch is based on v5.16-rc5 . I assumed that I would need to be based on acme/perf/urgent, but that seems to be based on 5.15
Thanks, John
| |