Messages in this thread | | | Date | Wed, 22 Dec 2021 11:17:52 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 6/9] backlight: qcom-wled: Remove unnecessary 4th default string in WLED3 |
| |
On Mon, 15 Nov 2021, Marijn Suijten wrote:
> The previous commit improves num_strings parsing to not go over the > maximum of 3 strings for WLED3 anymore. Likewise this default index for > a hypothetical 4th string is invalid and could access registers that are > not mapped to the desired purpose. > Removing this value gets rid of undesired confusion and avoids the > possibility of accessing registers at this offset even if the 4th array > element is used by accident. > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > drivers/video/backlight/qcom-wled.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |