Messages in this thread | | | Date | Wed, 22 Dec 2021 11:17:24 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 5/9] backlight: qcom-wled: Override default length with qcom,enabled-strings |
| |
On Mon, 15 Nov 2021, Marijn Suijten wrote:
> The length of qcom,enabled-strings as property array is enough to > determine the number of strings to be enabled, without needing to set > qcom,num-strings to override the default number of strings when less > than the default (which is also the maximum) is provided in DT. > > This also introduces an extra warning when qcom,num-strings is set, > denoting that it is not necessary to set both anymore. It is usually > more concise to set just qcom,num-length when a zero-based, contiguous > range of strings is needed (the majority of the cases), or to only set > qcom,enabled-strings when a specific set of indices is desired. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > --- > drivers/video/backlight/qcom-wled.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |