Messages in this thread | | | Date | Wed, 22 Dec 2021 11:15:48 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 2/9] backlight: qcom-wled: Pass number of elements to read to read_u32_array |
| |
On Mon, 15 Nov 2021, Marijn Suijten wrote:
> of_property_read_u32_array takes the number of elements to read as last > argument. This does not always need to be 4 (sizeof(u32)) but should > instead be the size of the array in DT as read just above with > of_property_count_elems_of_size. > > To not make such an error go unnoticed again the driver now bails > accordingly when of_property_read_u32_array returns an error. > Surprisingly the indentation of newlined arguments is lining up again > after prepending `rc = `. > > Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > drivers/video/backlight/qcom-wled.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |