Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 22 Dec 2021 12:21:01 +0200 | Subject | Re: [PATCH v11 04/15] iio: afe: rescale: expose scale processing function |
| |
On Wed, Dec 22, 2021 at 5:46 AM Liam Beguin <liambeguin@gmail.com> wrote: > > From: Liam Beguin <lvb@xiphos.com> > > In preparation for the addition of kunit tests, expose the logic > responsible for combining channel scales.
...
> #include <linux/gcd.h> > #include <linux/iio/consumer.h> > #include <linux/iio/iio.h> > +#include <linux/iio/afe/rescale.h>
It should go before the consumer.h, no?
And I would rather move the entire IIO group of headers...
> #include <linux/module.h> > #include <linux/of.h> > #include <linux/of_device.h> > #include <linux/platform_device.h> > #include <linux/property.h>
... somewhere here (with blank line above).
> > -struct rescale;
...
> +#ifndef __IIO_RESCALE_H__ > +#define __IIO_RESCALE_H__ > + > +#include <linux/iio/iio.h>
Missed types.h and forward declarations like struct device;
-- With Best Regards, Andy Shevchenko
| |