lkml.org 
[lkml]   [2021]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH V2] drm: nouveau: lsfw: cleanup coccinelle warning
Date
From: Wang Qing <wangqing@vivo.com>

odd_ptr_err.cocci has complained about this warning for a long time:
lsfw.c:194:5-11: inconsistent IS_ERR and PTR_ERR on line 195.

Although there is no actual impact, it can improve scanning efficiency.

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
index 9b1cf67..0f70d14
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c
@@ -191,7 +191,8 @@ nvkm_acr_lsfw_load_bl_inst_data_sig(struct nvkm_subdev *subdev,
u32 *bldata;
int ret;

- if (IS_ERR((lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id))))
+ lsfw = nvkm_acr_lsfw_add(func, acr, falcon, id);
+ if (IS_ERR(lsfw))
return PTR_ERR(lsfw);

ret = nvkm_firmware_load_name(subdev, path, "bl", ver, &bl);
--
2.7.4
\
 
 \ /
  Last update: 2021-12-23 03:25    [W:0.042 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site