Messages in this thread | | | Subject | Re: [PATCH] crypto: hisilicon/qm - cleanup warning in qm_vf_read_qos | From | "yekai(A)" <> | Date | Thu, 23 Dec 2021 10:16:14 +0800 |
| |
On 2021/12/23 9:51, Andy Shevchenko wrote: > > > On Wednesday, December 22, 2021, Kai Ye <yekai13@huawei.com > <mailto:yekai13@huawei.com>> wrote: > > The kernel test rebot report this warning: Uninitialized variable: ret. > Here is fix it. > > > How do you know that 0 is the correct value? > > > > Signed-off-by: Kai Ye <yekai13@huawei.com <mailto:yekai13@huawei.com>> > --- > drivers/crypto/hisilicon/qm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/crypto/hisilicon/qm.c > b/drivers/crypto/hisilicon/qm.c > index b1fe9c7b8cc8..c6e9ad2041c3 100644 > --- a/drivers/crypto/hisilicon/qm.c > +++ b/drivers/crypto/hisilicon/qm.c > @@ -4279,8 +4279,7 @@ static void qm_vf_get_qos(struct hisi_qm *qm, > u32 fun_num) > > static int qm_vf_read_qos(struct hisi_qm *qm) > { > - int cnt = 0; > - int ret; > + int cnt = 0, ret = 0; > > /* reset mailbox qos val */ > qm->mb_qos = 0; > -- > 2.33.0 > > > > -- > With Best Regards, > Andy Shevchenko > > we set the 0 to success in kernel style.
thanks Kai
| |