Messages in this thread | | | From | Muchun Song <> | Date | Wed, 22 Dec 2021 13:50:01 +0800 | Subject | Re: [PATCH v2] memcg: add per-memcg vmalloc stat |
| |
On Wed, Dec 22, 2021 at 1:25 PM Shakeel Butt <shakeelb@google.com> wrote: > [...] > @@ -2626,6 +2627,9 @@ static void __vunmap(const void *addr, int deallocate_pages) > unsigned int page_order = vm_area_page_order(area); > int i; > > + mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC, > + -(int)area->nr_pages);
The cast can go away since the type of 3rd parameter of mod_memcg_page_state() is int but not long. I suggest to remove it. Anyway
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Thanks.
| |