lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/8] hwmon: (adt7410) Pass name to core driver
From
Date
On 12/21/21 12:11 PM, Cosmin Tanislav wrote:
> From: Cosmin Tanislav <cosmin.tanislav@analog.com>
>
> It will later be used to register hwmon device using
> hwmon_device_register_with_info.
>
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> ---
> drivers/hwmon/adt7410.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/adt7410.c b/drivers/hwmon/adt7410.c
> index 973db057427b..ef4b5af865e9 100644
> --- a/drivers/hwmon/adt7410.c
> +++ b/drivers/hwmon/adt7410.c
> @@ -45,7 +45,7 @@ static int adt7410_i2c_probe(struct i2c_client *client)
> I2C_FUNC_SMBUS_BYTE_DATA | I2C_FUNC_SMBUS_WORD_DATA))
> return -ENODEV;
>
> - return adt7x10_probe(&client->dev, NULL, client->irq, &adt7410_i2c_ops);
> + return adt7x10_probe(&client->dev, client->name, client->irq, &adt7410_i2c_ops);
> }
>
> static int adt7410_i2c_remove(struct i2c_client *client)
>

This series looks very similar to the previous series, yet there is
no change log, and it again claims to be v1 of a patch series. Either
explain why this series is so different to the similar looking patch
series starting with "hwmon: adt7x10: store bus_dev in private data",
that it doesn't deserve to be called v2, or provide change logs and
version your series.

If you expect me to figure out what changed, sorry, that is not how
it works. I won't even look at this series.

Guenter

\
 
 \ /
  Last update: 2021-12-21 21:49    [W:0.044 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site