Messages in this thread | | | From | Paul Moore <> | Date | Tue, 21 Dec 2021 15:00:18 -0500 | Subject | Re: [PATCH v3] security/selinux: fix potential memleak in error branch |
| |
On Fri, Dec 10, 2021 at 7:04 AM Bernard Zhao <bernard@vivo.com> wrote: > > This patch try to fix potential memleak in error branch. > > Signed-off-by: Bernard Zhao <bernard@vivo.com> > > Changes since V1: > *make it to be simpler to do the "(!s)" check before the "(!opts)" check. > > Changes since v2: > *add *mnt_opts = NULL after kfree(opt) to avoid double free risk. > --- > security/selinux/hooks.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-)
Hi Bernard,
I apologize for the late response, this was lost in my inbox for some reason. Regardless, this looks fine to me so I'm merging it into selinux/next; thanks for your help.
However, Ondrej made a few good suggestions about further improvements that could be made up at the LSM layer, I think it would be nice if you could look into that too.
Thanks again for your help.
-- paul moore www.paul-moore.com
| |