lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] ASoC: Add AK4375 support
On Mon, Dec 20, 2021 at 08:37:25PM +0100, Vincent Knecht wrote:

> + SOC_ENUM("DACL Signal Invert", ak4375_invl_enum),
> + SOC_ENUM("DACR Signal Invert", ak4375_invr_enum),

These should really be a "DAC Signal Invert Switch" control rather than
an enum - really it's an on/off control for inversion. Other than that
the driver looks good so I'm going to go ahead and apply, please send an
incremental patch fixing this issue.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-12-21 18:56    [W:0.044 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site