lkml.org 
[lkml]   [2021]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/3] ASoC: SOF: AMD: simplify return status handling
    Date
    From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

    cppcheck warning:

    sound/soc/sof/amd/acp.c:222:9: warning: Identical condition and return
    expression 'ret', return value is always 0
    [identicalConditionAfterEarlyExit]
    return ret;
    ^
    sound/soc/sof/amd/acp.c:213:6: note: If condition 'ret' is true, the
    function will return/exit
    if (ret)
    ^
    sound/soc/sof/amd/acp.c:222:9: note: Returning identical expression 'ret'
    return ret;
    ^

    Just return 0; on success.

    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Reviewed-by: Ranjani Sridharan <ranjani.sridharan@intel.com>
    Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
    Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
    ---
    sound/soc/sof/amd/acp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
    index 4c5550e8d364..fe9b7dc5bc86 100644
    --- a/sound/soc/sof/amd/acp.c
    +++ b/sound/soc/sof/amd/acp.c
    @@ -219,7 +219,7 @@ int configure_and_run_sha_dma(struct acp_dev_data *adata, void *image_addr,
    return -EINVAL;
    }

    - return ret;
    + return 0;
    }

    int acp_dma_status(struct acp_dev_data *adata, unsigned char ch)
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-12-21 17:58    [W:3.253 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site